-
Couldn't load subscription status.
- Fork 25.6k
Add missing entitlement to repository-azure
#128047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing entitlement to repository-azure
#128047
Conversation
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
|
Hi @DaveCTurner, I've updated the changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks David
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
This entitlement is required, but only if validating the metadata endpoint against `https://login.microsoft.com/` which isn't something we can do in a test. Kind of a SDK bug, we should be using an existing event loop rather than spawning threads randomly like this.
This entitlement is required, but only if validating the metadata
endpoint against
https://login.microsoft.com/which isn't something wecan do in a test. Kind of a SDK bug, we should be using an existing
event loop rather than spawning threads randomly like this.
Closes #128046